drop GattServer::initializeGattDatabase()

public/BLE.h

@@ -444,15 +444,6 @@ public:
      * ble.gap().startAdvertising(...).
      */
     ble_error_t startAdvertising(void) {
-        /* HACK ALERT! the following bit with initializeGATTDatabase() is additional to
-         * gap().startAdvertising(). This was put in place to get some stacks to
-         * work--like CSR. We need to reach a point where this shouldn't be
-         * necessary. */
-        ble_error_t rc;
-        if ((rc = transport->getGattServer().initializeGATTDatabase()) != BLE_ERROR_NONE) {
-            return rc;
-        }
-
         return gap().startAdvertising();
     }
 

public/GattServer.h

@@ -136,8 +136,6 @@ public:
      */
     virtual ble_error_t write(Gap::Handle_t connectionHandle, GattAttribute::Handle_t, const uint8_t *, uint16_t, bool localOnly = false) = 0;
 
-    virtual ble_error_t initializeGATTDatabase(void) = 0;
-
     /**
      * Add a callback for the GATT event DATA_SENT (which is triggered when
      * updates are sent out by GATT in the form of notifications).